GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update setup.py by dciborow · Pull Request #784 · python/typing

Conversation

@dciborow

@dciborow dciborow commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

We got this package by mistake because the upper pin for Python is not set. The dataclasses package is a similar backport, but contains this pin.
https://github.com/ericvsmith/dataclasses

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dciborow
Update setup.py
a045e1b 
We got this package by mistake because the upper pin for Python is not set. The dataclasses package is a similar backport, but contains this pin.
https://github.com/ericvsmith/dataclasses
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Feb 11, 2021
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
@dciborow dciborow mentioned this pull request Feb 11, 2021
Python >3.6 is not restricted and causes accidently installation. #785
Closed
@dciborow

dciborow commented Feb 11, 2021

Copy link
Copy Markdown
Contributor Author

not sure how to reboot the CLA check, but i have since signed the agreement.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Feb 11, 2021

Copy link
Copy Markdown
Member

Honestly, maybe we should just limit this to 2.7 and 3.4? Note the comment stating that for 3.5 and up you need to upgrade Python. That’s because the stdlib has higher priority than sites-packages.

The CLA takes 1-2 business days, you have to click on “check yourself”.
dciborow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dciborow

dciborow commented Feb 13, 2021

Copy link
Copy Markdown
Contributor Author

#785
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dciborow
Update setup.py
ab9af38
@dciborow

dciborow commented Feb 13, 2021

Copy link
Copy Markdown
Contributor Author

@gvanrossum , updated to "<3.5". I thought this was the a little cleaner then <=3.4.*?

Checked CLA, not yet...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dciborow

dciborow commented Feb 16, 2021

Copy link
Copy Markdown
Contributor Author

fixed the first part of CELA request, (have bugs account, now pending CELA sig)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Feb 16, 2021

Copy link
Copy Markdown
Member

What's CELA? A misspelling of CLA? Or some variant that I don't know about?
dciborow reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Feb 18, 2021
@dciborow

dciborow commented Feb 19, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@gvanrossum , sorry "CELA" is our internal word for everything legal >.<. My fingers type python better then English.

Misspelling of CLA. Which looks good now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum merged commit c487c47 into python:master Mar 1, 2021
@dciborow
dciborow deleted the patch-1 branch March 1, 2021 23:59
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 11, 2021
New release #799
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@dciborow @the-knights-who-say-ni @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.