GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Remove duplicate test by AlexWaygood · Pull Request #123 · python/typing_extensions

Conversation

AlexWaygood commented Mar 6, 2023

Copy link

Copy Markdown

Member

This method is identical to test_hash_eq on lines 2296-2304:

typing_extensions/src/test_typing_extensions.py

Lines 2296 to 2304 in a0858e6

	def test_hash_eq(self):
	self.assertEqual(len({Annotated[int, 4, 5], Annotated[int, 4, 5]}), 1)
	self.assertNotEqual(Annotated[int, 4, 5], Annotated[int, 5, 4])
	self.assertNotEqual(Annotated[int, 4, 5], Annotated[str, 4, 5])
	self.assertNotEqual(Annotated[int, 4], Annotated[int, 4, 4])
	self.assertEqual(
	{Annotated[int, 4, 5], Annotated[int, 4, 5], Annotated[T, 4, 5]},
	{Annotated[int, 4, 5], Annotated[T, 4, 5]}
	)

(This is a backport of the only relevant part of python/cpython#102445)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Remove duplicate test

bf1add7

This method is identical to `test_hash_eq` on lines 2296-2304: https://github.com/python/typing_extensions/blob/a0858e6ba9b46996f3f74dde8749ab86e1561012/src/test_typing_extensions.py#L2296-L2304

(This is a backport of the only relevant part of python/cpython#102445)

JelleZijlstra approved these changes

Mar 6, 2023

View reviewed changes

JelleZijlstra merged commit ac52ac5 into python:main

Mar 6, 2023

AlexWaygood deleted the patch-1 branch

March 6, 2023 01:49

Reviewers

JelleZijlstra

JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.