GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Slightly cleanup implementation of typevarlikes by AlexWaygood · Pull Request #170 · python/typing_extensions

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented May 21, 2023

Copy link
Copy Markdown
Member

@JelleZijlstra this is what I was thinking of in #162 (review) when I said:

Feels like we could probably share more code between _TypeVarMeta, _ParamSpecMeta and _TypeVarTupleMeta, but that can definitely be tackled in a followup PR; no need to worry about it now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AlexWaygood and others added 2 commits May 22, 2023 00:10
@AlexWaygood
Slightly cleanup implementation of typevarlikes
2cb885b
@AlexWaygood
Update typing_extensions.py
c27df5c
@JelleZijlstra
JelleZijlstra merged commit 52c53f8 into python:main May 21, 2023
@AlexWaygood
AlexWaygood deleted the cleanup-typevarlikes branch May 21, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexWaygood @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.