GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Backport recent improvements to the implementation of `Protocol` by AlexWaygood · Pull Request #324 · python/typing_extensions

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jan 20, 2024

Copy link
Copy Markdown
Member

This backports python/cpython#112717 and python/cpython#113401. Fixes #323.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
Backport recent improvements to the implementation of Protocol
07a3079
AlexWaygood
AlexWaygood commented Jan 20, 2024
View reviewed changes
Comment thread src/test_typing_extensions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood added 4 commits January 20, 2024 15:06
@AlexWaygood
Restore being able to use typing_extensions.runtime_checkable on `t…
c9fdbc1 
…yping.Protocol`
@AlexWaygood
reduce diff
8dd0b5b
@AlexWaygood
add comment
0d92d3b
@AlexWaygood
fix docstring
ecd711b
JelleZijlstra
JelleZijlstra approved these changes Jan 20, 2024
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread CHANGELOG.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Update CHANGELOG.md
c858502
@JelleZijlstra
JelleZijlstra merged commit 004b893 into python:main Jan 20, 2024
@AlexWaygood
AlexWaygood deleted the protocol-backport branch January 20, 2024 18:10
@dolfinus

dolfinus commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

Could someone publish a release with this fix? Changes to Protocol implementation were backported from 3.13 to 3.12.2 which was released 06.02.2024. typing-extensions==4.9.0 is failing on this version
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dolfinus dolfinus mentioned this pull request Feb 14, 2024
[pre-commit.ci] pre-commit autoupdate MTSWebServices/onetl#213
Merged
@JelleZijlstra

JelleZijlstra commented Feb 14, 2024

Copy link
Copy Markdown
Member

We're expecting a new release in the next few weeks (for the implementations of PEPs 728 and 742). This particular issue seems too minor to warrant its own release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood mentioned this pull request Feb 15, 2024
Different results in Python 3.12.1 vs Python 3.12.2 #335
Closed
@AlexWaygood

AlexWaygood commented Feb 25, 2024

Copy link
Copy Markdown
Member Author

@dolfinus, typing_extensions 4.10.0 has now been released, which includes this fix :-)
dolfinus reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dolfinus

dolfinus commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

Thanks!
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Daily tests failed on Sat Jan 20 2024

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @dolfinus @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.