GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Remove unnecessary hasattr check from TypedDict by Daraan · Pull Request #533 · python/typing_extensions Conversation
Contributor
Adding @JelleZijlstra's PR python/cpython#109544 Including related additional tests from me python/cpython#130460 - not yet merged, hope that's fine.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Daraan
marked this pull request as draft
Co-authored-by: Jelle Zijlstra <[email protected]>
Daraan
force-pushed
the
TypedDict/backport__total__
branch
from
a3474f9 to
e2abebf
Compare
Daraan
marked this pull request as ready for review
JelleZijlstra
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, would you mind adding a changelog entry since this does change user-visible behavior in an edge case?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
JelleZijlstra
approved these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 2 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |