GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Reader and Writer protocols by srittau · Pull Request #582 · python/typing_extensions

Conversation

@srittau

@srittau srittau commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

Cf. python/cpython#127648

#565 would help with testing this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
srittau added 2 commits April 9, 2025 12:52
@srittau
Add Reader and Writer protocols
dad6e79 
Cf. python/cpython#127648
@srittau
Satisfy ruff
56bb7aa
JelleZijlstra
JelleZijlstra reviewed Apr 9, 2025
View reviewed changes
Comment thread CHANGELOG.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@srittau
Merge branch 'main' into reader-writer
fcdc3b7
AlexWaygood
AlexWaygood reviewed Apr 28, 2025
View reviewed changes
Comment thread CHANGELOG.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood reviewed Apr 28, 2025
View reviewed changes
Comment thread src/typing_extensions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
srittau and others added 2 commits April 28, 2025 14:29
@srittau
Fix CHANGELOG
14f72d5
@srittau @AlexWaygood
Remove merge artifact
687d453 
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood reviewed Apr 28, 2025
View reviewed changes
Comment thread src/typing_extensions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood reviewed Apr 28, 2025
View reviewed changes
Comment thread src/test_typing_extensions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/test_typing_extensions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@srittau @AlexWaygood
Apply suggestions from code review
9e72db2 
Co-authored-by: Alex Waygood <[email protected]>
JelleZijlstra
JelleZijlstra approved these changes Apr 28, 2025
View reviewed changes
@AlexWaygood

AlexWaygood commented Apr 28, 2025

Copy link
Copy Markdown
Member

Should we add a mention of these to https://github.com/python/typing_extensions/blob/main/doc/index.rst ?
srittau reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srittau
Add doc entry
555ca2f
srittau
srittau commented Apr 28, 2025
View reviewed changes
Comment thread doc/index.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@srittau
Link to Python 3.14 docs
da0587b
AlexWaygood
AlexWaygood reviewed Apr 29, 2025
View reviewed changes
Comment thread src/typing_extensions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/typing_extensions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
srittau and others added 2 commits April 29, 2025 14:09
@srittau @AlexWaygood
Use italics in docstring
b59461b 
Co-authored-by: Alex Waygood <[email protected]>
@srittau
Silence flake8
f6e2fb0
AlexWaygood
AlexWaygood approved these changes Apr 29, 2025
View reviewed changes
@srittau
srittau merged commit f02b99d into python:main Apr 30, 2025
@srittau
srittau deleted the reader-writer branch April 30, 2025 13:08
@yashwanthatla yashwanthatla mentioned this pull request Jun 21, 2025
Replication of original PR #582: Add Reader and Writer protocols yashwanthatla/typing_extensions#4
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@srittau @AlexWaygood @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.