GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix error message when subclassing TypeVarTuple by JanEricNitschke · Pull Request #679 · python/typing_extensions

Conversation

@JanEricNitschke

@JanEricNitschke JanEricNitschke commented Sep 13, 2025

Copy link
Copy Markdown
Contributor

Issue discovered by running CPython 3.12 test_typing.py on typing_extensions: https://github.com/JanEricNitschke/typing_extensions/actions/runs/17692936537/job/50288896717#step:7:120

Test from here: https://github.com/python/cpython/blob/main/Lib/test/test_typing.py#L1526

Regex from here (adjusted to also handle typing_extensions): https://github.com/python/cpython/blob/main/Lib/test/test_typing.py#L61

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JanEricNitschke added 2 commits September 13, 2025 11:01
@JanEricNitschke
Fix error message when subclassing TypeVarTuple
0774aec
@JanEricNitschke
Silence ruff warning in test
d9c83c0
@codecov

codecov Bot commented Sep 13, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.39%. Comparing base (f7dbe27) to head (b088f82).
⚠️ Report is 43 commits behind head on main.

@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
- Coverage   97.39%   97.39%   -0.01%     
==========================================
  Files           3        3              
  Lines        7767     7793      +26     
==========================================
+ Hits         7565     7590      +25     
- Misses        202      203       +1
Flag Coverage Δ
3.10 89.06% <85.71%> (-0.02%) ⬇️
3.10.4 89.06% <85.71%> (-0.02%) ⬇️
3.11 88.32% <89.28%> (+<0.01%) ⬆️
3.11.0 87.56% <89.28%> (+<0.01%) ⬆️
3.12 88.28% <89.28%> (+0.01%) ⬆️
3.12.0 88.27% <89.28%> (+0.01%) ⬆️
3.13 81.82% <75.00%> (-0.01%) ⬇️
3.13.0 82.54% <75.00%> (-0.01%) ⬇️
3.14 78.28% <75.00%> (+<0.01%) ⬆️
3.9 89.77% <85.71%> (-0.02%) ⬇️
3.9.12 89.77% <85.71%> (-0.02%) ⬇️
pypy3.10 88.90% <85.71%> (-0.02%) ⬇️
pypy3.11 88.18% <89.28%> (+<0.01%) ⬆️
pypy3.9 89.60% <85.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/test_typing_extensions.py 98.39% <100.00%> (-0.02%) ⬇️
src/typing_extensions.py 94.00% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JanEricNitschke added 4 commits September 13, 2025 14:51
@JanEricNitschke
Fix subclassing message for 3.10- and instance subclassing
244ddf7
@JanEricNitschke
Fix __more_entries__
29af0f0
@JanEricNitschke
Fix expected regex for Unpack subclassing
b15af16
@JanEricNitschke
Take Unpack error messages out of scope
cd5cd00
JelleZijlstra
JelleZijlstra reviewed Sep 15, 2025
View reviewed changes
Comment thread src/typing_extensions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JanEricNitschke @JelleZijlstra
Fix whitespace
a49d36d 
Co-authored-by: Jelle Zijlstra <[email protected]>
brianschubert
brianschubert reviewed Sep 15, 2025
View reviewed changes
Comment thread CHANGELOG.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JanEricNitschke
Update changelog entry
9156388
@JelleZijlstra

JelleZijlstra commented May 1, 2026

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Merge branch 'main' into fix-typevar-tuple-subclass-error
b088f82
@JanEricNitschke

JanEricNitschke commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Anything i can/should still do here? Conflict is only in the changelog.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
+1 more reviewer
@brianschubert brianschubert brianschubert left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JanEricNitschke @JelleZijlstra @brianschubert
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.