GeezerVison

Should be WIN32, that way building in Debug on windows using Ninja will work as expected.

Should probably be something like :

set(_limited_definition)
if(NOT "${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
    math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}")
    set(_limited_definition "Py_LIMITED_API=0x${_limited_api_version}0000")
endif()

That said, the approach should still be tweaked to handle the case of Visual Studio where CMAKE_CONFIGURATION_TYPES is defined

@dbrnz I had an other look at this, and if Py_LIMITED_API must not be defined when doing Debug build, relying on a newer version of CMake supporting generator expression would be the way to go.

That way, we will be able to do something like this:

math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}")
target_compile_definition(xxlimited PRIVATE $<$<NOT:$<CONFIG:Debug>>:${_limited_definition}>)