GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add fix for replacing snprinf for MSVS version with existing snprintf by o01eg · Pull Request #251 · python-cmake-buildsystem/python-cmake-buildsystem

Conversation

@o01eg

@o01eg o01eg commented May 26, 2019

Copy link
Copy Markdown

See: https://bugs.python.org/issue36020

Fixes #250

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@o01eg
o01eg force-pushed the fix-pyerror-msvs-snprintf branch from dc2c413 to 659fb2c Compare May 26, 2019 20:07
@o01eg
Add fix for replacing snprinf for MSVS version with existing snprintf
880c349 
See: https://bugs.python.org/issue36020
@o01eg
o01eg force-pushed the fix-pyerror-msvs-snprintf branch from 659fb2c to 880c349 Compare May 30, 2019 21:04
This was referenced Jun 8, 2019
Fix python re-declaring snprinf for MSVC already supports it freeorion/freeorion#2467
Merged
Update boost and python-cmake freeorion/freeorion-sdk#49
Merged
thewtex
thewtex approved these changes Jun 10, 2019
View reviewed changes

@thewtex thewtex left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @o01eg!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thewtex

thewtex commented Jun 10, 2019

Copy link
Copy Markdown
Contributor

@jcfr can this please be merged?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@thewtex thewtex thewtex approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apply fix for snprintf in pyerror.h

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@o01eg @thewtex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.