GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: disable vcdiv64.asm on non-x86_64 Windows by bjia56 · Pull Request #409 · python-cmake-buildsystem/python-cmake-buildsystem

Conversation

@bjia56

@bjia56 bjia56 commented May 30, 2025

Copy link
Copy Markdown
Contributor

Required for building on Windows arm64.

https://github.com/python/cpython/blob/3.12/PCbuild/_decimal.vcxproj#L140-L146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bjia56
fix: disable vcdiv64.asm on non-x86_64 Windows
f379941
jamesobutler
jamesobutler reviewed May 30, 2025
View reviewed changes

@jamesobutler jamesobutler left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjia56 Do you need Windows on ARM testing in the CI? I see that there is now the windows-11-arm GitHub runner

https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bjia56 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
bjia56 added 2 commits May 30, 2025 16:18
@bjia56
add windows-11-arm to CI
ef78b77
@bjia56
Revert "add windows-11-arm to CI"
2f90049 
This reverts commit ef78b77.
@bjia56

bjia56 commented May 30, 2025

Copy link
Copy Markdown
Contributor Author

@jamesobutler It's a good idea, however I'm not too sure how to plug it into the existing GH runner setup.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jamesobutler

jamesobutler commented May 30, 2025

Copy link
Copy Markdown
Contributor

Adding Windows 11 arm building would likely need to be restricted to the Python 3.11+ builds. It appears that the Python organization distributed Windows arm64 installers for Python 3.11.0 (https://www.python.org/downloads/release/python-3110/), but did not for earlier versions such as Python 3.10.7 (https://www.python.org/downloads/release/python-3107/).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bjia56

bjia56 commented May 30, 2025

Copy link
Copy Markdown
Contributor Author

fwiw, I was able to get 3.9 and 3.10 builds when testing my portable fork here: bjia56/portable-python#129
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesobutler jamesobutler jamesobutler left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bjia56 @jamesobutler
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.