GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Merge conda recipes by bnavigator · Pull Request #143 · python-control/Slycot

Conversation

@bnavigator

@bnavigator bnavigator commented Jan 8, 2021

Copy link
Copy Markdown
Collaborator

Merge all conda recipes into one. This builds on top of #142.

  • In conda, only compile against the NETLIB headers.
    • https://conda-forge.org/docs/maintainer/knowledge_base.html#blas
    • Uses Accelerate framework instead of the blas package from conda-forge conda-forge/slycot-feedstock#23
  • Test with different installed LAPACK/BLAS implementation libraries.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
bnavigator force-pushed the merge-recipes branch 2 times, most recently from 0df0f45 to ea2341f Compare January 8, 2021 16:18
@roryyorke

roryyorke commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

LGTM. I'll leave it to you to merge, so you can decide on sequence of this vs #140.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator Author

Let's give @repagh some time to chime in.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator requested a review from repagh January 9, 2021 11:49
@bnavigator
bnavigator force-pushed the merge-recipes branch from ea2341f to 6439535 Compare January 11, 2021 20:39
@bnavigator
merge conda-recipes
77b28a4
@bnavigator
bnavigator force-pushed the merge-recipes branch from 6439535 to 77b28a4 Compare January 11, 2021 20:46
@bnavigator bnavigator mentioned this pull request Jan 11, 2021
GitHub workflow #140
Merged
8 tasks done
@bnavigator

bnavigator commented Jan 14, 2021

Copy link
Copy Markdown
Collaborator Author

I changed some README paragraphs reflecting the new merged conda recipe situation.

With Python 3.6+ The windows compiler is the same for all versions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@roryyorke

roryyorke commented Jan 24, 2021

Copy link
Copy Markdown
Collaborator

This is now part of #140?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Jan 24, 2021

Copy link
Copy Markdown
Collaborator Author

Not necessarily. The branch for #140 just is based on this branch. So merge this first, then #140. Or, if #140 is merged, this PR will automatically be merged as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator added 2 commits January 24, 2021 10:25
@bnavigator
Update REAMDE.rst for conda single recipe and general compiling instr…
f5c5db4 
…uctions
@bnavigator
update MANIFEST
2e22674
@bnavigator
bnavigator force-pushed the merge-recipes branch from d53b54f to 2e22674 Compare January 24, 2021 09:26
@roryyorke
roryyorke merged commit 2e22674 into python-control:master Jan 30, 2021
@bnavigator
bnavigator deleted the merge-recipes branch May 3, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@repagh repagh Awaiting requested review from repagh

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bnavigator @roryyorke
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.