GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test ag08bd agnostic of Af-lambda*Ef scaling by bnavigator · Pull Request #158 · python-control/Slycot

Conversation

@bnavigator

@bnavigator bnavigator commented Oct 31, 2021

Copy link
Copy Markdown
Collaborator

Fixes #157

From the AG08BD.f docstring:

C     PURPOSE
C
C     To extract from the system pencil
C
C                       ( A-lambda*E B )
C           S(lambda) = (              )
C                       (      C     D )
C
C     a regular pencil Af-lambda*Ef which has the finite Smith zeros of
C     S(lambda) as generalized eigenvalues. The routine also computes
C     the orders of the infinite Smith zeros and determines the singular
C     and infinite Kronecker structure of system pencil, i.e., the right
C     and left Kronecker indices, and the multiplicities of infinite
C     eigenvalues.

As reported in #157, some math libraries out there compute Af, Ef with a different scaling as the SLICOT example. The result should still be valid.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
test ag08bd agnostic of Af-lambda*Ef scaling
c9ebc70
@bnavigator

bnavigator commented Oct 31, 2021

Copy link
Copy Markdown
Collaborator Author

I verified this on Arch Linux, which failed before: https://build.opensuse.org/package/show/home:bnavigator:archlinux/python-slycot
carlosal1015 reacted with thumbs up emoji pacosalces reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@roryyorke

roryyorke commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator

Looks good to me; from Wikipedia the generalized eigenvalue problem is Af @ x == lambda * Ef @ x, so Af and Ef are not unique.

This change can't be causing the test failures. I see control/tests/flatsys_test.py::TestFlatSys::test_point_to_point_errors is common to all the failing runs, and that two cases fail control/tests/timeresp_test.py::TestTimeresp::test_forced_response_T_U[dt=True, no T] and control/tests/timeresp_test.py::TestTimeresp::test_forced_response_T_U[dt=0.2, no T]. I don't have any suggestions for this, except the not-so-helpful one of ignoring the failures and merging anyway.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator Author

Thanks.

The mentioned failures should be fixed by python-control/python-control#659. I just retriggered the CI jobs now. If it succeeds, all is well. If not, we can still ignore.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit 223fdd7 into python-control:master Nov 9, 2021
@bnavigator
bnavigator deleted the fix-157 branch May 3, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A test test_tg01fd.test4_ag08bd failure

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bnavigator @roryyorke
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.