GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add ab08nz function to support complex state-space systems by lytex · Pull Request #96 · python-control/Slycot

Conversation

@lytex

@lytex lytex commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

add ab08nz function to support regular pencil for complex state-space systems

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lytex lytex mentioned this pull request Apr 1, 2020
Complex matrices python-control/python-control#376
Closed
@bnavigator

bnavigator commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

Please add one or more unit tests here as discussed in python-control/python-control#376
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lytex

lytex commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

I've written a simple test for both ab08nd and ab08nz.

ab08nd works fine but ab08nz SEGFAULTs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Apr 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

I sent you a PR lytex#1. If you accept, this PR here will be updated. See also https://github.com/bnavigator/Slycot/tree/complex-pyf for Travis CI results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@roryyorke roryyorke mentioned this pull request Apr 10, 2020
Time to release a new version? #98
Closed
roryyorke
roryyorke requested changes Apr 11, 2020
View reviewed changes

@roryyorke roryyorke left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two docstring changes requested.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread slycot/analysis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread slycot/analysis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
roryyorke
roryyorke approved these changes Apr 11, 2020
View reviewed changes
lytex and others added 10 commits April 12, 2020 09:53
@lytex @roryyorke
add ab08nz function to support regular pencil for complex state-space…
2f78306 
… systems
@lytex @roryyorke
add ab08n* tests (ab08nd executes successfully, ab08nz SEGFAULTs)
42ee06f
@bnavigator @roryyorke
clean __init__
203dc75
@bnavigator @roryyorke
rework signatures for ab08nd and ab08nz
8f06d66
@bnavigator @roryyorke
rework analysis.ab08nz() function
e2471dc
@bnavigator @roryyorke
extend tests for ab08nX
da58b7d
@bnavigator @roryyorke
fix docstring
96ae4bf
@bnavigator @roryyorke
remove complex warning in ab08nz
96d9890
@bnavigator @roryyorke
add the test file to CMakeLists.txt
021a5c4
@bnavigator @roryyorke
readd tolerance calculation docstring, reformat lzwork docstring
d397dbb
@roryyorke
roryyorke force-pushed the master branch from fabad2b to d397dbb Compare April 12, 2020 08:12
@roryyorke
roryyorke merged commit ee1f019 into python-control:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments
@roryyorke roryyorke roryyorke approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@lytex @bnavigator @roryyorke
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.