GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — process legacy rlocus keyword k->gains by gdmcbain · Pull Request #1003 · python-control/python-control

Conversation

@gdmcbain

@gdmcbain gdmcbain commented May 13, 2024

Copy link
Copy Markdown
Contributor

As requested by @bnavigator in review of #999.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gdmcbain
process legacy keyword k->gains python-control#999
206ca85
@coveralls

coveralls commented May 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.504% (+0.001%) from 94.503%
when pulling 12865cf on gdmcbain:rlocus-k
into 6178097 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented May 18, 2024

Copy link
Copy Markdown
Contributor

The coverage does not change much because the line is run unconditionally, but could you please add a unit test which passes the keywords in question and checks for their proper handling?
gdmcbain reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gdmcbain
gdmcbain marked this pull request as draft May 21, 2024 04:18
@gdmcbain
test deprecated 'k' keyword for rlocus
b58f435
@gdmcbain
gdmcbain marked this pull request as ready for review May 22, 2024 06:55
@gdmcbain
Merge branch 'main' into rlocus-k
12865cf
@bnavigator

bnavigator commented May 22, 2024

Copy link
Copy Markdown
Contributor

Thank you! The doctest failure is unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit 7a209f7 into python-control:main May 22, 2024
@gdmcbain
gdmcbain deleted the rlocus-k branch May 22, 2024 23:35
@murrayrm murrayrm added this to the 0.10.1 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gdmcbain @coveralls @bnavigator @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.