GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix parallel input or output interconnect bug (issue #1015) by murrayrm · Pull Request #1017 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jun 29, 2024

Copy link
Copy Markdown
Member

This PR fixes the bug identified in #1015, where specification of a list of signals as the input was not handled properly (each signal in the list was treated as a separate input rather than connecting a single input to the list). There was a similar bug in the output processing code. Unit test that exposes the bug included.

I think this code can be cleaned up a bit (to avoid the duplication in processing for the two cases), but want to get a fix out quickly since there is no easy workaround.

(Also found and fixed a typo in a docstring.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
fix interconnect() issue python-control#1015
2e872f8
@coveralls

coveralls commented Jun 29, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.515% (+0.009%) from 94.506%
when pulling 2e872f8 on murrayrm:interconnect_bug-29Jun2024
into e5394c4 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm linked an issue Jun 29, 2024 that may be closed by this pull request
"Interconnect" input specification. #1015
Closed
@murrayrm murrayrm added this to the 0.10.1 milestone Jun 30, 2024
@murrayrm
updated documentation per comment from @bonidydy in python-control#1015
421131c
@coveralls

coveralls commented Jun 30, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.542% (+0.04%) from 94.506%
when pulling 421131c on murrayrm:interconnect_bug-29Jun2024
into e5394c4 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Jul 2, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.542% (+0.04%) from 94.506%
when pulling 1d239a7 on murrayrm:interconnect_bug-29Jun2024
into e5394c4 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
code cleanup
1964a86
@murrayrm
murrayrm force-pushed the interconnect_bug-29Jun2024 branch from 1d239a7 to 1964a86 Compare July 2, 2024 05:06
@coveralls

coveralls commented Jul 2, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.539% (+0.006%) from 94.533%
when pulling 1964a86 on murrayrm:interconnect_bug-29Jun2024
into 4acc78b on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller reviewed Jul 2, 2024
View reviewed changes
Comment thread control/nlsys.py Outdated
specification (including the optional gain term). Numbered outputs
must be chosen from the list of subsystem outputs, but named
outputs can also be contained in the list of subsystem inputs.
mapped to overall system outputs. The entris for a connection are

@sawyerbfuller sawyerbfuller Jul 2, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: “entries”

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
fix type pointed out by @sawyerbfuller
9a78e33
@coveralls

coveralls commented Jul 2, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.539% (+0.006%) from 94.533%
when pulling 9a78e33 on murrayrm:interconnect_bug-29Jun2024
into 4acc78b on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
slivingston
slivingston reviewed Jul 3, 2024
View reviewed changes
Comment thread control/nlsys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
fixed small indent error
584f39d
slivingston
slivingston approved these changes Jul 7, 2024
View reviewed changes
@coveralls

coveralls commented Jul 7, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.55% (+0.02%) from 94.533%
when pulling 584f39d on murrayrm:interconnect_bug-29Jun2024
into 4acc78b on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit 8c1ddec into python-control:main Jul 7, 2024
@murrayrm
murrayrm deleted the interconnect_bug-29Jun2024 branch July 7, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller left review comments
@slivingston slivingston slivingston approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

"Interconnect" input specification.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@murrayrm @coveralls @slivingston @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.