GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix incorrect attribute name in `control.combine_time_responses` function by diemilio · Pull Request #1026 · python-control/python-control

Conversation

@diemilio

@diemilio diemilio commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

fixes #1025 by renaming the incorrectly used types attribute of TimeResponseData objects to trace_types

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@diemilio diemilio changed the title Update timeplot.py Fix wrong attribute name in control.combine_time_responses function Jul 10, 2024
@diemilio diemilio changed the title Fix wrong attribute name in control.combine_time_responses function Fix incorrect attribute name in control.combine_time_responses function Jul 10, 2024
@coveralls

coveralls commented Jul 10, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.628%. remained the same
when pulling 70d9761 on diemilio:main
into 6406868 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston

slivingston commented Jul 10, 2024

Copy link
Copy Markdown
Member

@diemilio Thanks! Can you add a regression test that demonstrates the bug?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm closed this Jul 13, 2024
@murrayrm
murrayrm force-pushed the main branch from 70d9761 to bb82883 Compare July 13, 2024 16:22
@murrayrm

murrayrm commented Jul 13, 2024

Copy link
Copy Markdown
Member

Not quite sure what happened, but I didn't mean to close this...

I added a regression test. Need to figure out how to retrieve it (apologies @diemilio!).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm mentioned this pull request Jul 13, 2024
Update timeplot.py #1030
Merged
@diemilio

diemilio commented Jul 13, 2024

Copy link
Copy Markdown
Contributor Author

No problem. Sorry I could not get to add the tests earlier, so thanks for adding this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm added this to the 0.10.1 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

control.combine_time_responses fails to combine time responses

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@diemilio @coveralls @slivingston @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.