GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move ctrlplot code prior to upcoming PR by murrayrm · Pull Request #1033 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jul 21, 2024

Copy link
Copy Markdown
Member

This PR moves around some functions from freqplot.py and timeplot.py to ctrlplot.py in preparation for an upcoming PR that is going to modify those functions. There is no change in functionality, but I want people to be able to see the changes I am making to functions in ctrlplot.py in the upcoming PR => need to move things around first so that git diff can highlight the changes.

Summary of changes:

  • The rcParams dict used to customize plotting functions is now in ctrlplot.py (instead of having two separate but identical rcParams in freqplot.py and timpelot.py).
  • The _process_ax_keyword utility function is now in ctrlplot.py (instead of freqplot.py).
  • The _process_line_labels utility function is now in ctrlplot.py (instead of freqplot.py).
  • The _get_line_labels utility function is now in ctrlplot.py (instead of freqplot.py).
  • The _add_arrows_to_line2D utility function is now in ctrlplot.py (instead of freqplot.py).
  • Rearranged some functions in grid.py.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 2 commits July 9, 2024 07:40
@murrayrm
move code around to new locations
234e6ec
@murrayrm
move code around in grid.py
c67da3a
@coveralls

coveralls commented Jul 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.629%. remained the same
when pulling 009b821 on murrayrm:ctrlplot_refactor-27Jun2024
into da64e0e on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
slivingston
slivingston approved these changes Jul 21, 2024
View reviewed changes
slivingston
slivingston reviewed Jul 21, 2024
View reviewed changes
Comment thread control/ctrlplot.py Outdated
# Utility functions
#
# These functions are used by plotting routines to provide a consistent way
# of processing and displaing information.

@slivingston slivingston Jul 21, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# of processing and displaing information.
# of processing and displaying information.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
fix small typo caught by @slivingston
009b821
@murrayrm
murrayrm merged commit 1a276dc into python-control:main Jul 21, 2024
@murrayrm
murrayrm deleted the ctrlplot_refactor-27Jun2024 branch July 21, 2024 16:45
sawyerbfuller
sawyerbfuller reviewed Jul 21, 2024
View reviewed changes

@sawyerbfuller sawyerbfuller left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm murrayrm added this to the 0.10.1 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slivingston slivingston slivingston approved these changes
@sawyerbfuller sawyerbfuller sawyerbfuller left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@murrayrm @coveralls @slivingston @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.