GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update OS/BLAS test matrix workflow by murrayrm · Pull Request #1036 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Aug 8, 2024

Copy link
Copy Markdown
Member

This PR updates the OS/BLAS test matrix workflow that is used to test releases against various combinations of operating systems and BLAS implementations. Changes:

  • Found and fixed an issue in nyquist_test.py in which some calls with a manually specified frequency response would generate a user warning and others wouldn't. Both cases are not handled properly (and a redundant check has been removed).
  • Fixed some issues with paths for OpenBLAS on macos that were causing compiler errors.
  • Updated pip-based tests to check out current branch instead of main (mainly useful when using a development branch, like this one).

No changes to the actual control toolbox itself.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 4 commits August 6, 2024 21:43
@murrayrm
fixed incorrect unit test in nyquist_test (OS/BLAS test matrix failure
c2bebea
@murrayrm
update MacOS, pip, OpenBLAS to fix path issue
a377bdc
@murrayrm
remove rendudant (and improperly implemented) Nyquist unit test
19a8d5c
@murrayrm
update pip test wheel to checkout current branch, not main
f94b9cf
@murrayrm murrayrm added this to the 0.10.1 milestone Aug 8, 2024
@coveralls

coveralls commented Aug 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.65%. remained the same
when pulling 25e9474 on murrayrm:test_matrix_update-06Aug2024
into b385a9e on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
slivingston
slivingston reviewed Aug 8, 2024
View reviewed changes
Comment thread control/tests/nyquist_test.py Outdated
assert issubclass(records[0].category, UserWarning)
assert "encirclements does not match" in str(records[0].message)
else:
pytest.fails("multiple warnings in nyquist_response (?)")

@slivingston slivingston Aug 8, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pytest.fails("multiple warnings in nyquist_response (?)")
pytest.fail("multiple warnings in nyquist_response (?)")

https://docs.pytest.org/en/stable/reference/reference.html#pytest-fail

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
pytest.fails -> pytest.fail in nyquist_test.py
25e9474
@murrayrm
murrayrm merged commit d1cf152 into python-control:main Aug 8, 2024
@murrayrm
murrayrm deleted the test_matrix_update-06Aug2024 branch August 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slivingston slivingston slivingston left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @slivingston
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.