GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Upgrade GitHub action dependencies: upload-artifact, download-artifact by slivingston · Pull Request #1046 · python-control/python-control

Conversation

@slivingston

@slivingston slivingston commented Sep 3, 2024

Copy link
Copy Markdown
Member

Following deprecation notice at https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@slivingston
CI: upgrade upload-artifact, download-artifact
c22d0f4 
Following deprecation notice at https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
@slivingston slivingston mentioned this pull request Sep 3, 2024
Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows #1045
Closed
@slivingston

slivingston commented Sep 3, 2024

Copy link
Copy Markdown
Member Author

The automatically generated pull request (#1045) was broken because it did not also upgrade upload-artifact, but doing so is required, as noted in the README of download-artifact.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Sep 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.694%. remained the same
when pulling 3d9baa1 on upgrade-download-github-action
into 6d42088 on main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston
CI: unique upload names given immutability
3d9baa1 
Reference: https://github.com/actions/download-artifact/blob/fa0a91b85d4f404e444e00e005971372dc801d16/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact
@slivingston
slivingston force-pushed the upgrade-download-github-action branch from d2a75db to 3d9baa1 Compare September 4, 2024 01:09
@slivingston slivingston mentioned this pull request Sep 4, 2024
Upgrade GitHub action dependencies: upload-artifact, download-artifact python-control/Slycot#236
Merged
@murrayrm
murrayrm merged commit 220ace3 into main Sep 4, 2024
@murrayrm
murrayrm deleted the upgrade-download-github-action branch September 4, 2024 06:31
@murrayrm murrayrm added this to the 0.10.2 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@slivingston @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.