GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve code style, markov by KybernetikJo · Pull Request #1051 · python-control/python-control

Conversation

@KybernetikJo

@KybernetikJo KybernetikJo commented Oct 17, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Improve code style, markov:

  • Add space after commas

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@KybernetikJo
Add space after commas
df71ed6
@KybernetikJo KybernetikJo changed the title Improves code style, markov Improve code style, markov Oct 17, 2024
@KybernetikJo
Update docstring hash for markov
b70c0ed
@coveralls

coveralls commented Oct 19, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.694%. remained the same
when pulling b70c0ed on KybernetikJo:improve_style_markov
into 220ace3 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KybernetikJo

KybernetikJo commented Oct 19, 2024

Copy link
Copy Markdown
Contributor Author

@murrayrm
I don't understand why a new hash was necessary. The docstring has not changed!
I have updated the hash for markov.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Oct 19, 2024

Copy link
Copy Markdown
Member

Because this function uses *args, we use a hash of the docstring and the function text to ensure that the developer confirms that arguments are still documented properly (by updating the hash).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit d75082d into python-control:main Oct 19, 2024
@murrayrm murrayrm added this to the 0.10.2 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@KybernetikJo @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.