GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update nyquist_plot to call nyquist_response correctly by murrayrm · Pull Request #1096 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jan 14, 2025

Copy link
Copy Markdown
Member

This PR addresses issue #1095, where some arguments to nyquist_plot were not being processed correctly. The issue was that not all arguments to nyquist_plot that needed to be passed through for processing in nyquist_response were listed. The fix was to pass a dictionary of keywords to nyquist_response in a way that it could pop elements off of the dictionary that it processed, leaving only those that nyquist_plot needs to handle.

I also added some unit tests that expose this bug and also check to make sure that all of other relevant response/plot function pairs pass on arguments correctly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
update nyquist_plot to call nyquist_response with all args + unit tests
6db1a1c
@murrayrm murrayrm linked an issue Jan 14, 2025 that may be closed by this pull request
Nyquist plot indent direction doesn't seem to work #1095
Closed
@coveralls

coveralls commented Jan 14, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.687% (+0.001%) from 94.686%
when pulling 54c4fd9 on murrayrm:fix_nyquist_plot-13Jan2025
into ec7dc8a on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston
slivingston self-requested a review January 14, 2025 06:47
slivingston
slivingston reviewed Jan 15, 2025
View reviewed changes

@slivingston slivingston left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this fixes the error and the test catches it. I found a couple of small misprints; else, this is good to merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread control/tests/response_test.py Outdated
# processed by _response(), then we need to make sure that arguments are
# properly passed from _plot() to _response(). The unit tests in this file
# make sure that this functionality is implemented properly across all
# *relevan* _response/_map/plot pairs.

@slivingston slivingston Jan 14, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# *relevan* _response/_map/plot pairs.
# *relevant* _response/_map/plot pairs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread control/tests/response_test.py Outdated
# input_output_response time_response_plot no passthru args
# nyquist_response nyquist_plot included below
# pole_zero_map pole_zero_plot no passthru args
# root_locus_map pole_zero_plot included below

@slivingston slivingston Jan 15, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# root_locus_map pole_zero_plot included below
# root_locus_map root_locus_plot included below

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
fix small typos per @slivingston review
54c4fd9
@murrayrm
murrayrm merged commit 0ff0452 into python-control:main Jan 16, 2025
@murrayrm murrayrm added this to the 0.10.2 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slivingston slivingston slivingston left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

Nyquist plot indent direction doesn't seem to work

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @slivingston
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.