GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Handle scalar `timeresp` in `solve_flat_ocp` by roryyorke · Pull Request #1111 · python-control/python-control

Conversation

@roryyorke

@roryyorke roryyorke commented Feb 1, 2025

Copy link
Copy Markdown
Contributor

Fixes gh-1110.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
roryyorke added 2 commits February 1, 2025 13:31
@roryyorke
Add test for scalar timepts arg in solve_flat_ocp
52ab45e
@roryyorke
Handle scalar timepts arg in solve_flat_ocp
b7eeb79 
Fixes python-controlgh-1110.
@coveralls

coveralls commented Feb 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.659% (+0.01%) from 94.649%
when pulling a05b9d5 on roryyorke:gh1110-solve_flat_ocp
into ebff125 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Feb 1, 2025
View reviewed changes
Comment thread control/tests/flatsys_test.py Outdated
Comment on lines +473 to +475
assert np.max(abs(r1.x-r2.x)) == 0
assert np.max(abs(r1.u-r2.u)) == 0
assert np.max(abs(r1.y-r2.y)) == 0

@bnavigator bnavigator Feb 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a fancy way to say r1.x == r2.x while employing some opaque shape casting?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@roryyorke roryyorke Feb 1, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just laziness! fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@roryyorke
Use assert_array_equal to compare results in scalar timeresp test
a05b9d5
@roryyorke

roryyorke commented Feb 1, 2025

Copy link
Copy Markdown
Contributor Author

the failures are during install optional dependencies phase, before tests are run, and must be unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Feb 1, 2025

Copy link
Copy Markdown
Member

Reran the tests and that fixed the problem.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit 2cb0520 into python-control:main Feb 1, 2025
@murrayrm murrayrm added this to the 0.10.2 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

solve_flat_ocp and scalar timepts

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@roryyorke @coveralls @murrayrm @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.