GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix color cycling not working in singular_values_plot by lkies · Pull Request #1138 · python-control/python-control

Conversation

@lkies

@lkies lkies commented Mar 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This seems to have been caused by a name collision between the function scope color variable and the loop-"local" color variable. The first time _get_color is called it will replace the function level color so in the next iteration a colorspec is explicitly passed to _get_color so it will no longer automatically cycle through colors.

Closes #1134

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lkies
fix color cycling not working in singular_values_plot
d61e6d4 
this seems to have ben caused by a name collision between the function scope color variable and the loop-"local" color variable.
the first time _get_color is called it will replace the function level color so in the next iteration a color is explicitly passed to _get_color so it will no longer automatically cycle through colors.
@lkies

lkies commented Mar 2, 2025

Copy link
Copy Markdown
Contributor Author

And I guess the broken CI checks will also fail for this one...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Mar 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.744%. remained the same
when pulling 049a716 on lkies:fix-svp
into f6799ab on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Mar 2, 2025

Copy link
Copy Markdown
Member

Thanks @lkies. We should also add a unit test to catch the issue and verify it is fixed. You can find one here: murrayrm@904516f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lkies
test to verify that color cycling works for singular_values_plot
049a716
@lkies

lkies commented Mar 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@murrayrm No problem, I added your test, but why not just merge your own changes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Mar 2, 2025

Copy link
Copy Markdown
Member

I was waiting until we fixed the CI error before generating the PR, but since you had done the fix in parallel, definitely fine to use yours.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm added this to the 0.10.2 milestone Mar 3, 2025
@murrayrm
murrayrm merged commit ad996f9 into python-control:main Mar 3, 2025
@murrayrm murrayrm mentioned this pull request Jun 24, 2025
singular_values_plot plots systems with the same color #1160
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

Singular values plot not changing colors for list of systems

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@lkies @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.