GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add type error checks, unit tests, documentation for real-valued systems by murrayrm · Pull Request #1142 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Mar 24, 2025

Copy link
Copy Markdown
Member

This PR addresses #1141 which suggested putting in checks for unsupported coefficient types in transfer functions (specifically complex numbers). This PR does that, including some small additions to the documentation and unit tests.

Note that attempting to pass a complex coefficient for a state space system was already caught as an error.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 2 commits March 23, 2025 22:39
@murrayrm
add error checks, unit tests, documentation for real-valued systems
d9affba
@murrayrm
fix unintended use of complex coefficient in examples/cruise.ipynb
6b4501e
@murrayrm murrayrm linked an issue Mar 24, 2025 that may be closed by this pull request
Casting complex number to float #1141
Closed
@coveralls

coveralls commented Mar 24, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 94.747% (+0.002%) from 94.745%
when pulling 6b4501e on murrayrm:xferfcn_typecheck-23Mar2025
into 394e1c2 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator approved these changes Mar 25, 2025
View reviewed changes

@bnavigator bnavigator left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
bnavigator merged commit dc7d71b into python-control:main Mar 25, 2025
@murrayrm murrayrm added this to the 0.10.2 milestone Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

Casting complex number to float

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.