GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix ax processing bug in {nyquist,nichols,describing_function}_plot by murrayrm · Pull Request #1145 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Apr 17, 2025

Copy link
Copy Markdown
Member

This PR fixes #1144 (also pointed out in #1143) where the ax keyword was being ignored in the nyquist_plot command.

Turns out that there were several related bugs:

  • The Nichols grid was not being plotted in the proper location when ax was passed to nichols_plot.
  • The describing function curve was not being plotted in the proper location when ax was passed to describing_funciton_plot.

This PR fixes those bugs as well, and includes an updated unit test that picks up all three previous errors.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 2 commits April 16, 2025 23:15
@murrayrm
fix ax processing bug in {nyquist,nichols,describing_function}_plot
2764889
@murrayrm
fix ruff error in descfcn.py (matplotlib no longer needed)
21f4912
@coveralls

coveralls commented Apr 17, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 94.746% (-0.001%) from 94.747%
when pulling 21f4912 on murrayrm:fix_nyquist_ax-16Apr2025
into dc7d71b on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston
slivingston self-requested a review April 17, 2025 19:49
@slivingston
slivingston merged commit 632391c into python-control:main Apr 17, 2025
@murrayrm murrayrm added this to the 0.10.2 milestone Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slivingston slivingston Awaiting requested review from slivingston

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

Nyquist plot uses incorrect subplot axes

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @slivingston
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.