GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix CI errors in NumPy 2.3.1 by murrayrm · Pull Request #1163 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jul 4, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR fixes a couple of CI errors that arose in NumPy 2.3.1 and that hadn't shown up prior to this:

  • In optimal.py, there was a bug in saving old values of an array, where copy() should have been used.
  • In lti.py, there seems to be a difference in the way numpy.multiply returns values (perhaps due to rounding?) that was causing transfer functions with complex coefficients when using c2d.

Fixes for both are very small and I'll merge this quickly so that I can release 0.10.2 this weekend.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 2 commits July 4, 2025 08:28
@murrayrm
fix gh1161 by creating copy correctly
ffcc2a6
@murrayrm
fix rounding error issue showing up in NumPy 2.3.1
a359e8b
@coveralls

coveralls commented Jul 4, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 94.745%. remained the same
when pulling a359e8b on murrayrm:fix_optimal-03Jul2024
into aa92b65 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm added this to the 0.10.2 milestone Jul 4, 2025
@murrayrm
murrayrm merged commit 2745b12 into python-control:main Jul 4, 2025
@murrayrm murrayrm mentioned this pull request Jul 5, 2025
Slycot CI check failing #1161
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@murrayrm @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.