GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Robust hinfsyn: add suboptimal synth by wuschel-brompf · Pull Request #1184 · python-control/python-control

Conversation

@wuschel-brompf

@wuschel-brompf wuschel-brompf commented Nov 4, 2025

Copy link
Copy Markdown

to obtain numerically more robust controllers, usually a slightly suboptimal controller is synthesized after running the first optimization.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
wuschel-brompf added 2 commits November 4, 2025 12:18
@wuschel-brompf
add suboptimal controller generation option to hinfsyn in control/rob…
1ffc334
…ust.py
@wuschel-brompf
add default value
22b533e
@ilayn

ilayn commented Nov 4, 2025

Copy link
Copy Markdown

Note that this relaxation works typically OK with LMI based design since you introduce slackness but for Riccati based solvers there are no guarantees that this improves the conditioning of the controllers. This is typically due to the bilinear nature of the problem. It works OK for smooth-enough problems though.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

murrayrm
murrayrm requested changes Nov 9, 2025
View reviewed changes

@murrayrm murrayrm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, @wuschel-brompf. I had a few things that I think should be updated to be consistent with our coding conventions and to provide a bit more information to the user.

Also, we need a unit test that covers the new code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread control/robust.py


def hinfsyn(P, nmeas, ncon):
def hinfsyn(P, nmeas, ncon, gamTry=None):

@murrayrm murrayrm Nov 9, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter name doesn't not follow python-control naming conventions. From the developer notes:

Use longer description parameter names that describe the action or role (e.g., trajectory_constraints and print_summary in optimal.solve_optimal_trajectory.

I suggest something like target_gamma for this parameter name.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread control/robust.py
ncon : int
Number of control inputs (output from controller).
gamTry : int, optional
Target performance level (default = None).

@murrayrm murrayrm Nov 9, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is consistent with the current very terse docstring, I think a bit more information is needed, either here or in a Notes section later in the docstring. Something like:

If target_gamma is specified, then a controller with the target value of $\gamma$ will be generated. This is potentially suboptimal, but save computation time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@coveralls

coveralls commented Nov 9, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 94.717% (-0.02%) from 94.734%
when pulling 22b533e on wuschel-brompf:robust_hinfsyn_add_suboptimal_synth
into 2435a6a on python-control:main.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm

murrayrm commented Jan 19, 2026

Copy link
Copy Markdown
Member

@wuschel-brompf: Will you be able to update the PR to address the earlier comments?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murrayrm murrayrm murrayrm requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@wuschel-brompf @ilayn @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.