GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Honor explicit Nyquist indent direction near imaginary axis by marko1olo · Pull Request #1223 · python-control/python-control

Conversation

@marko1olo

@marko1olo marko1olo commented Jun 7, 2026

Copy link
Copy Markdown

Fixes #1194.

Summary

  • detect when indent_direction was explicitly supplied
  • honor explicit left/right for poles within indent_radius, even when the pole has a small nonzero real part
  • preserve existing automatic side selection when no direction is passed
  • add a regression test for a near-imaginary-axis pole where explicit right and left must produce opposite real offsets

Tests

  • MPLBACKEND=Agg python -m pytest control\tests\nyquist_test.py::test_nyquist_indent_near_imaginary_axis control\tests\nyquist_test.py::test_nyquist_indent_default control\tests\nyquist_test.py::test_nyquist_indent_dont control\tests\nyquist_test.py::test_nyquist_indent_do control\tests\nyquist_test.py::test_nyquist_indent_left control\tests\nyquist_test.py::test_nyquist_indent_im control\tests\nyquist_test.py::test_no_indent_pole -q
  • MPLBACKEND=Agg python -m pytest control\tests\nyquist_test.py -q (24 passed, 1 existing xpass, 1 warning)
  • python -m ruff check control\freqplot.py control\tests\nyquist_test.py
  • python -m compileall -q control\freqplot.py control\tests\nyquist_test.py
  • git diff --check

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@marko1olo
fix(nyquist): honor explicit indent direction
820514d 
Preserve automatic near-axis indentation when no direction is passed, but let explicit left/right override pole-side selection for poles within the indent radius.

Fixes python-control#1194
@coveralls

coveralls commented Jun 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.73% (-0.006%) from 94.736% — marko1olo:fix-nyquist-indent-direction into python-control:main
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marko1olo

marko1olo commented Jun 7, 2026

Copy link
Copy Markdown
Author

I checked the remaining failed check. The test suite itself passed, including the Nyquist tests:

3816 passed, 555 skipped, 11 xfailed, 1 xpassed

The job failed afterward in coverallsapp/github-action@v2 while downloading/verifying the Coveralls binary checksum. The downloaded coveralls-checksums.txt content was a GitHub HTML “Unicorn!” error page, so this looks like an external coverage upload/bootstrap failure rather than a code/test failure in this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit 17baf62 into python-control:main Jun 8, 2026
33 of 34 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@dongxuelian2 dongxuelian2 mentioned this pull request Nov 3, 2026
Fix Nyquist indentation geometry and automatic direction selection #1265
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nyquist_response ignores indent_direction unless poles have exactly zero real part

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@marko1olo @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.