GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||
GeezerVison is showing github.com — Don't fail in step_info() if the rise-time level is never reached by syahra712 · Pull Request #1259 · python-control/python-control Conversation
>>> import control as ct >>> ct.step_info(ct.tf([2.99, -0.0685], [1, 2.83])) IndexError: index 0 is out of bounds for axis 0 with size 0 This system is stable. The step response starts at 2.99, from the feedthrough, and decays to the DC gain of -0.0242. The default time vector ends at about 2.44 s, where the response is about -0.021. That is only about 87% of the final value, so Fix: if either rise-time level is never reached, Tests: added
AI-assisted (Claude): I used it to help read the code and draft the test. I reviewed and ran everything myself.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsIf the response never reaches the rise time limits (e.g. the default time vector ends too early for a system with a large feedthrough transient), np.nonzero(...)[0][0] raised IndexError. Leave RiseTime, SettlingMin and SettlingMax as NaN in that case.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |