GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix discrete-time frequency handling in describing_function_response by gimballock · Pull Request #1272 · python-control/python-control

Conversation

@gimballock

@gimballock gimballock commented Nov 5, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

For a discrete-time system, describing_function_response found limit cycles with about the right amplitude but reported the wrong frequency: it took the oscillation frequency as the imaginary part of the Nyquist contour, which for a discrete system lies on the unit circle exp(1j*w*dt), so it reported about sin(w*dt) - the same number whatever dt is. The refinement cost function and the returned positions also evaluated H at z = 1j*w rather than on the unit circle, and refinement typically failed with "not able to refine result; returning estimate".

For example, H(z) = 0.5/(z^2 - 0.5z) with dt = 1 crosses the negative real axis at w = 1.3181, but the reported frequency was 0.9703, and dt = 0.5 gave the same 0.9703 instead of 2.6362.

When H.isdtime(strict=True) - matching the timebase semantics used by nyquist_response - take the frequencies as np.angle(contour) / dt and evaluate H at exp(1j*w*dt) in the refinement cost function and for the returned positions. The strict check keeps dt=None (unspecified timebase) on the continuous-time path; dt=True (discrete, unspecified sample time) reports rad/sample.

Adds regression tests: a known unit-circle crossing for dt = 1 and dt = 0.5, plus dt=None continuous-equivalence and dt=True coverage. The discrete tests fail at baseline; continuous-time behavior is unchanged.

Fixes #1269

written by claude opus 5.5, reviewed by me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@RoboX2020
Fix discrete-time frequency handling in describing_function_response
3b3c005
For a discrete-time system, describing_function_response found limit
cycles with about the right amplitude but reported the wrong frequency:
it took the oscillation frequency as the imaginary part of the Nyquist
contour, which for a discrete system lies on the unit circle
exp(1j*w*dt), so it reported about sin(w*dt) - the same number whatever
dt is.  The refinement cost function and the returned positions also
evaluated H at z = 1j*w rather than on the unit circle, and refinement
typically failed with "not able to refine result; returning estimate".

For example, H(z) = 0.5/(z^2 - 0.5z) with dt = 1 crosses the negative
real axis at w = 1.3181, but the reported frequency was 0.9703, and
dt = 0.5 gave the same 0.9703 instead of 2.6362.

When H.isdtime(strict=True) - matching the timebase semantics used by
nyquist_response - take the frequencies as np.angle(contour) / dt and
evaluate H at exp(1j*w*dt) in the refinement cost function and for the
returned positions.  The strict check keeps dt=None (unspecified
timebase) on the continuous-time path; dt=True (discrete, unspecified
sample time) reports rad/sample.

Adds regression tests: a known unit-circle crossing for dt = 1 and
dt = 0.5, plus dt=None continuous-equivalence and dt=True coverage.
The discrete tests fail at baseline; continuous-time behavior is
unchanged.

Fixes python-control#1269
@slivingston

slivingston commented Nov 6, 2026

Copy link
Copy Markdown
Member

In explaining your contribution, do not use AI to automatically generate comments, pull request descriptions, or issue descriptions.

https://numpy.org/doc/stable/dev/ai_policy.html

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@slivingston slivingston closed this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

describing_function_response reports sin(w*dt), not w, for discrete-time systems, and refines at z = jw

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gimballock @slivingston @RoboX2020
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.