GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — Add run of tests without Slycot on Travis CI by slivingston · Pull Request #133 · python-control/python-control Conversation
Member
Because tests and parts of The second commit disables tests that depend on Slycot if it is not found. Affected tests were introduced in PR #118.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionstestBalredMatchDC, testGramRc, testGramRo which were introduced in PR #118 use functions that depend on Slycot, so the tests should be skipped if it is not found.
|
There was an error while loading. Please reload this page.
|
Coverage remained the same at 77.329% when pulling a7e0bba on testing into 5ab74cf on master. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Changes here increase runtime for CI builds by approximately 90 seconds (as a sum across all configurations: Python 2.7, 3.3, 3.4, 3.5). There is at least one negative consequence of changes here. Tests that are independent of Slycot are performed twice without potential benefit. However, the marginal gain in computation time and load is small. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Looks good. I assume you saw all the deprecation warnings from scipy. FWIW, an alternative is to use Travis CI's matrix capability; I imagine "with Slycot" and "without Slycot" configurations. Using a matrix setup opens other possibilities:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR looks good to me. Will merge in 24 hours if there are no further comments. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@slivingston: leaving it to you to delete the branch (just in case there is some reason to keep it). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@roryyorke and @murrayrm thanks to both of you for reviews. re #133 (comment):
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.