GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix numpy generated warnings that are breaking unit tests by murrayrm · Pull Request #232 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jul 29, 2018

Copy link
Copy Markdown
Member

The latest version of numpy marks the matrix class as something that is pending deprecation. The warnings generated by numpy were breaking some of the python-control unit tests (see numpy-discussion thread). This PR fixes the unit tests that were causing problems by filtering the warning messages to only include those from python-control.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 2 commits July 29, 2018 14:30
@murrayrm
update statesp_test.py unit test to fix numpy warnings
70bf207
@murrayrm
update freqresp_test.py unit test to fix numpy warnings
53e0a09
@coveralls

coveralls commented Jul 29, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 78.914% when pulling 53e0a09 on murrayrm:fix-statesp_test-warnings into a007fcc on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm mentioned this pull request Jul 29, 2018
Decide on how to handle (to be deprecated?) np.matrix class #233
Closed
@murrayrm
murrayrm merged commit 71101bf into python-control:master Jul 29, 2018
@murrayrm
murrayrm deleted the fix-statesp_test-warnings branch July 29, 2018 22:16
This was referenced Jul 29, 2018
Updated numpy is causing unit test error #231
Closed
Unit tests failing after merging PR #34 python-control/Slycot#35
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@murrayrm @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.