GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add _repr_latex_ for Jupyter notebooks by alchemyst · Pull Request #276 · python-control/python-control

Conversation

@alchemyst

@alchemyst alchemyst commented Feb 24, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This allows better representation inside the browser:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ilayn and don4get reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@coveralls

coveralls commented Feb 24, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.5%) to 77.92% when pulling 6cbe066 on alchemyst:master into e4e7a0d on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@coveralls

coveralls commented Feb 24, 2019

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-13.5%) to 64.872% when pulling 426215e on alchemyst:master into 31e6944 on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm murrayrm mentioned this pull request Feb 24, 2019
Travis CI failing on slycot builds #277
Closed
@murrayrm

murrayrm commented Feb 24, 2019

Copy link
Copy Markdown
Member

Change looks fine, but getting a Travis CI error.

It would be nice to put in this type of functionality for the other LTI subtypes (StateSpace, FRD, etc). Any chance you have the time and inclination to do that as well?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@alchemyst

alchemyst commented Feb 25, 2019

Copy link
Copy Markdown
Contributor Author

I'd be happy to take a run at it, but perhaps we could start by opening issues for the others? I'd specifically like to know what format you'd prefer for the state space.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm murrayrm mentioned this pull request Feb 25, 2019
Create latex output for Jupyter notebooks #278
Open
@repagh repagh mentioned this pull request Mar 19, 2019
install scikit-build for testing with slycot #280
Merged
@murrayrm

murrayrm commented Mar 26, 2019

Copy link
Copy Markdown
Member

@alchemyst Can you merge changes from latest master to get Travis CI working again (see PR #280 for more info). Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alchemyst added 2 commits March 27, 2019 05:20
@alchemyst
Add _repr_latex_ for Jupyter notebooks
c7e1e10
@alchemyst
Swap rows and columns in _repr_latex_
e6dccbf
@alchemyst
alchemyst force-pushed the master branch from 6595db3 to e6dccbf Compare March 27, 2019 03:21
@alchemyst

alchemyst commented Mar 27, 2019

Copy link
Copy Markdown
Contributor Author

@murrayrm ✅

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@repagh

repagh commented Mar 27, 2019

Copy link
Copy Markdown
Member

Nice, looks good.
Would it be worthwhile to build the outstr as a list, and at the end return the string with
''.join(outstr)
I expect that to be faster.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@alchemyst
Build list instead of concatenating strings
6cbe066
@alchemyst

alchemyst commented Mar 28, 2019

Copy link
Copy Markdown
Contributor Author

@repagh Done.

My initial implementation was a copy-paste of the current __str__. Perhaps we should add an issue for someone to make the same changes there?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@repagh

repagh commented Apr 5, 2019

Copy link
Copy Markdown
Member

@murrayrm I think this looks OK to merge

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm murrayrm added this to the 0.8.2 milestone Apr 6, 2019
@murrayrm
murrayrm merged commit c30746a into python-control:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.8.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@alchemyst @coveralls @murrayrm @repagh
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.