GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Rework at step_info by joaoantoniocardoso · Pull Request #293 · python-control/python-control

Conversation

@joaoantoniocardoso

@joaoantoniocardoso joaoantoniocardoso commented Apr 17, 2019

Copy link
Copy Markdown
Contributor

Hi,

I did some rework trying to fix some issues that it found using control.step_info(), specially when I tried to compare with MATLAB for some system with inverted output like sys = control.TransferFunction([0.0002, -0.0002], [1, 0.01, 0.0002]).

Another thread that I found was that the output resolution for control.step_response() for discrete systems, so I increased it using the idea of MATLAB, that produces the output with all samples for a particular discrete system from 0 to steady state. Also, I noticed that MATLAB thinks differently about how to define the size of the arrays for step... but i didn't mess with it this time, it is working fine.

Besides that, I have no clue about what undershoot should be like.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
joaoantoniocardoso added 8 commits April 17, 2019 00:25
@joaoantoniocardoso
Fixing a minor error with some discrete-time systems
cf7885c
@joaoantoniocardoso
Removing unneeded code.
5538d96
@joaoantoniocardoso
Resolution added for discrete-time systems.
712b16f
@joaoantoniocardoso
Fixing a possible mistake
90374b6
@joaoantoniocardoso
Treating systems with negative step responses
d5e7895
@joaoantoniocardoso
Treating systems with negative step responses
e47ba8d
@joaoantoniocardoso
Merge pull request #1 from python-control/master
5f4f001 
updating last commits
@joaoantoniocardoso
Merge branch 'master' of https://github.com/joaoantoniocardoso/python…
1ab6756 
…-control
@joaoantoniocardoso

joaoantoniocardoso commented Apr 17, 2019

Copy link
Copy Markdown
Contributor Author

Oops, I did break the tests for step, really missed somewhere. I'll look it soon and pull again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaoantoniocardoso joaoantoniocardoso closed this Apr 17, 2019
@joaoantoniocardoso joaoantoniocardoso mentioned this pull request Aug 21, 2019
Any plan for step_info to support negative step responses? #337
Closed
@murrayrm murrayrm added this to the 0.8.3 milestone Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.8.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@joaoantoniocardoso @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.