GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Arrow head length and head width option is added in nyquist_plot function by geekonloose · Pull Request #379 · python-control/python-control

Conversation

@geekonloose

@geekonloose geekonloose commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
geekonloose added 3 commits March 4, 2020 17:51
@geekonloose
Nyquist_plot changed to accommodate arrow size
b28e9ab
@geekonloose
color option is added
a4f2d25
@geekonloose
formatting
f5f05bd
@coveralls

coveralls commented Mar 4, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 84.599% when pulling 7c96781 on geekonloose:master into dab8ff6 on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@geekonloose geekonloose mentioned this pull request Mar 4, 2020
arrow size in Nyquist plot #377
Closed
@murrayrm

murrayrm commented Mar 4, 2020

Copy link
Copy Markdown
Member

It looks like the line style or something changed so that every line in the is marked as deleted then added.

Can you try to reset the line style back to the original so that we can see only those lines that changed? Much easier to track updates that way.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

geekonloose added 3 commits March 5, 2020 08:14
@geekonloose
formatting is retained
5de0899
@geekonloose
line formatting corrected
8f8565b
@geekonloose
again line formatting
1f4885d
@geekonloose

geekonloose commented Mar 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

My editor was automatically formatting to pep8 format sorry for that. I have reformatted file as possible. I have checked with file compare in vs code (with the original file in python-control), it was able to show the changes. However, GitHub is showing so many deletions. If you want, I can provide line-numbers where I have made changes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm

murrayrm commented Mar 5, 2020

Copy link
Copy Markdown
Member

Can you just go back to the original file and only edit the lines that actually need to be changed? Just putting the lines changed in the PR comments won't let people see what actually changed if they do git diff.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm

murrayrm commented Mar 5, 2020

Copy link
Copy Markdown
Member

Looks like 8f8565b fixed the problem but then 1f4885d changed it back?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm

murrayrm commented Mar 5, 2020

Copy link
Copy Markdown
Member

Also: I suggest using keywords that are more descriptive than hw and hl. How about arrowhead_width and arrowhead_length?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@geekonloose

geekonloose commented Mar 5, 2020

Copy link
Copy Markdown
Contributor Author

ok I will do that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@geekonloose
hl changed to arrowhead_width and hw changed to arrowhead_length
7c96781
@murrayrm
murrayrm merged commit 874d52e into python-control:master Mar 18, 2020
@murrayrm murrayrm mentioned this pull request Mar 18, 2020
arrows in nyquist plot #303
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@geekonloose @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.