GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add capability to switch to legacy defaults by sawyerbfuller · Pull Request #424 · python-control/python-control

Conversation

@sawyerbfuller

@sawyerbfuller sawyerbfuller commented Jun 26, 2020

Copy link
Copy Markdown
Contributor

For example, config.use_legacy_defaults('0.8.3')

  • as suggested by murrayrm in use dt=0 instead of dt=None (unspecified timebase) as default option for lti systems? #422

I added a few more defaults that might change in the future, but left them as they currently are for this PR:
* statesp.remove_useless_states (issue #244) (currently True; future is False? )
* statesp and xferfcn.default_dt (issue #422) (currently None, future is 0?)
* statesp.use_numpy_matrix (currently True, future is False)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sawyerbfuller added 2 commits June 26, 2020 11:47
@sawyerbfuller
add capability to switch to legacy defaults with config.use_legacy_de…
c7ba6fd 
…faults(version)
@sawyerbfuller
reverted to using matrix as default in statesp to pass tests
85b0f5e
@coveralls

coveralls commented Jun 26, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 84.215% when pulling 68c7ea6 on sawyerbfuller:legacy-defaults into a9d869e on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Jun 27, 2020

Copy link
Copy Markdown
Member

Changes look good. I think the docstrings for the various functions need to be updated to indicate the default values come from config variables. We should also add the new variables to the documentation in doc/.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sawyerbfuller
added documentation to statesp, xferfcn, and conventions.rst describi…
68c7ea6 
…ng new config parameters default_dt and remove_useless_states
@murrayrm

murrayrm commented Jun 28, 2020

Copy link
Copy Markdown
Member

Looks ready to merge. Will let sit for a few days in case others want to comment.
sawyerbfuller, repagh, and bnavigator reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit ce3a231 into python-control:master Jul 11, 2020
@murrayrm murrayrm mentioned this pull request Jul 11, 2020
control.matlab.markov does not work #395
Closed
@sawyerbfuller
sawyerbfuller deleted the legacy-defaults branch July 15, 2020 04:25
@sawyerbfuller
sawyerbfuller restored the legacy-defaults branch July 15, 2020 04:40
@sawyerbfuller
sawyerbfuller deleted the legacy-defaults branch July 15, 2020 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sawyerbfuller @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.