GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — do not override squeeze parameter in forced_response by bnavigator · Pull Request #442 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

squeeze=False does not work for forced_response() because the parameter is unnecessarily overridden by a shortcut alias to np.squeeze.

The current code timeresp_test.py advertises to test this, but actually does not. (#438 does now, that's how I stumbled over it.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
do not override squeeze parameter in forced_response
bc65000
@coveralls

coveralls commented Jul 31, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 84.212% when pulling bc65000 on bnavigator:fix-squeeze-override into d3142ff on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Jul 31, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 84.222% when pulling bc65000 on bnavigator:fix-squeeze-override into d3142ff on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator mentioned this pull request Jul 31, 2020
Refactor the test suite using pytest for array and matrix types #438
Merged
@bnavigator

bnavigator commented Aug 16, 2020

Copy link
Copy Markdown
Contributor Author

@murrayrm, this is a fix but it changes user facing behavior. I am not sure whether it should go to 0.8.4 or 0.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Aug 16, 2020

Copy link
Copy Markdown
Member

I think we could argue that this sort of fix is OK in 0.8.4, given that it probably wasn't really used much (since nobody complained that it was broken).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Aug 17, 2020

Copy link
Copy Markdown
Contributor Author

Yes, looking at git blame, the squeeze parameter was introduced into master by #295 last year and only existed in 0.8.3 since January. No squeeze=False usages by many users then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator added this to the 0.8.4 milestone Aug 17, 2020
@bnavigator

bnavigator commented Aug 17, 2020

Copy link
Copy Markdown
Contributor Author

Any objections to merge now?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Aug 17, 2020

Copy link
Copy Markdown
Member

OK by me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Aug 17, 2020

Copy link
Copy Markdown
Contributor Author

Excercising my newly received privileges then. Thanks for adding me to the team 😃
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit 2d61988 into python-control:master Aug 17, 2020
@sawyerbfuller sawyerbfuller mentioned this pull request Aug 17, 2020
proposal to standardize squeezing output from systems #453
Closed
@bnavigator
bnavigator deleted the fix-squeeze-override branch January 5, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.8.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bnavigator @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.