GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix matlab.stepinfo() by bnavigator · Pull Request #444 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Aug 1, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#420 broke control.matlab.stepinfo(). Ironically this was the only wrapper function not covered by the unit tests. New test in #438 now.

  • ✖️ Travis CI fail pre fix (I have no idea why the slycot source jobs pass. Maybe wrong commit checkout. Travis seems to have general issues right now, the hyperlinks to those runs are missing on the correspondig commits in Return type of eigenvalues from lqr and lqe not consistent #439)
  • ✔️ Travis CI after fix

(As always, change diff settings to ignore whitespace for easier review. Actual, change is just one line)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
fix matlab stepinfo
5543fb6
@coveralls

coveralls commented Aug 1, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 84.222% when pulling 5543fb6 on bnavigator:fix-matlab-stepinfo into d3142ff on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@coveralls

coveralls commented Aug 1, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 84.222% when pulling 5543fb6 on bnavigator:fix-matlab-stepinfo into d3142ff on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator mentioned this pull request Aug 1, 2020
Refactor the test suite using pytest for array and matrix types #438
Merged
@bnavigator bnavigator added this to the 0.8.4 milestone Aug 16, 2020
@bnavigator
bnavigator merged commit c6a000f into python-control:master Aug 17, 2020
@bnavigator
bnavigator deleted the fix-matlab-stepinfo branch January 5, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.8.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bnavigator @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.