GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Extend returnScipySignalLTI() to discrete systems by bnavigator · Pull Request #445 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Aug 2, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

These were not covered by the tests, so I wrote some tests and found out it is not that hard to extend them to discrete systems.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
bnavigator force-pushed the extend-tf2scipylti branch from cf0b866 to a8aa41e Compare August 2, 2020 22:32
@coveralls

coveralls commented Aug 2, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.3%) to 86.618% when pulling d6d77dc on bnavigator:extend-tf2scipylti into 26206dc on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Aug 2, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.3%) to 84.489% when pulling a8aa41e on bnavigator:extend-tf2scipylti into d3142ff on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator mentioned this pull request Aug 2, 2020
Refactor the test suite using pytest for array and matrix types #438
Merged
@bnavigator bnavigator added this to the 0.9.0 milestone Aug 16, 2020
@sawyerbfuller

sawyerbfuller commented Aug 20, 2020

Copy link
Copy Markdown
Contributor

Returning a cont-time scipy system when dt=None seems like a reasonable choice (I think in scipy, dt=None actually means cont time).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller approved these changes Aug 20, 2020
View reviewed changes

@sawyerbfuller sawyerbfuller left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
bnavigator force-pushed the extend-tf2scipylti branch from a3336a4 to edd29fd Compare August 20, 2020 17:52
@bnavigator

bnavigator commented Aug 20, 2020

Copy link
Copy Markdown
Contributor Author

Re current CI fail: #456
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator added the enhancement label Aug 20, 2020
@bnavigator
bnavigator force-pushed the extend-tf2scipylti branch from edd29fd to 1e7c714 Compare August 21, 2020 19:03
@bnavigator
bnavigator force-pushed the extend-tf2scipylti branch from 1e7c714 to 86069d0 Compare December 28, 2020 23:58
@bnavigator
returnScipySignalLTI for discrete systems
d6d77dc 
and add unit tests
@bnavigator
bnavigator force-pushed the extend-tf2scipylti branch from 86069d0 to d6d77dc Compare December 29, 2020 04:54
@bnavigator
bnavigator merged commit 51c797e into python-control:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bnavigator @coveralls @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.