GeezerVison

@bnavigator any idea how soon #438 will be ready for prime time? I can plan to try to merge (and figure out how to do that) when you’re done with the PR.

Hi,

I think it is ready. But it depends on the yet unmerged PRs mentioned in the initial post. We should get those approved and merged first. I understand #438 is hard to review. The diff will get smaller with the underlying PRs though.

Coverage decreased (-0.07%) to 87.438% when pulling a631098 on sawyerbfuller:call-method into 4103688 on python-control:master.

Coverage decreased (-0.2%) to 84.032% when pulling 2c4ac62 on sawyerbfuller:call-method into d3142ff on python-control:master.

A few comments: sys.horner was modified slightly so that it only takes care of the low-level algorithm, while __call__ is intended to perform user friendly tasks like input formatting and squeezing the output as necessary.

most recent commit moves the task of calling slycot and fall-back if it doesn't work into sys.horner

ok I think ive resolved doc comments with the last two commits

Travis isnt happy about somethng though.

Build 940 and 941 got canceled and 942 didn't start yet. We have to wait a little.

And the day when we can ditch Travis for a different CI will be a happy day for me. (Working on Github Actions for Slycot right now in python-control/Slycot#140, and then I will tackle #446)

Ok looks like Travis is happy now. I’m happy to have it merged but don’t understand the various options, happy to leave it to @murrayrm and @bnavigator discretion.