GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — updated markov() to add tranpose keyword + default warning by murrayrm · Pull Request #478 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Dec 24, 2020

Copy link
Copy Markdown
Member

This PR partially addresses issue #395 by adding a transpose keyword to the markov function that allows transposed inputs. In the current release, the markov function is not consistent with the normal time-series convention (see discussion in #395) so a warning message is generated if transpose is not set explicitly to True.

These files will need to be updated again in the 0.9.0 release so that the default for the transpose keyword changes from True to False.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
updated markov() to add tranpose keyword + default warning; tests, PEP8
7ed68ec
@coveralls

coveralls commented Dec 24, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 86.328% when pulling 438c178 on murrayrm:markov-inconsistency into 120a926 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Dec 24, 2020

Copy link
Copy Markdown
Contributor

This PR itself LGTM. But are we sure that the algorithm actually works for real data? The data used in the test is worthless to determine any markov parameters. (#395 (comment))
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
updated markov calculation + new unit tests
bb15b85
@murrayrm

murrayrm commented Dec 26, 2020

Copy link
Copy Markdown
Member Author

Good point on whether the calculation was right. Looks like it wasn't...

In this latest push, I have:

  • Updated the markov() algorithm to compute the correct coefficients (the old code is there for comparison, along with a new algorithm + reference).
  • Reverted to the original markov_test.py (to make sure tests are backward compatible) and moved all of the "enhanced" testing into markov_test_array.py.
  • Added a new unit test in markov_test_array.py to make sure the calculation is correct.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm linked an issue Dec 26, 2020 that may be closed by this pull request
control.matlab.markov does not work #395
Closed
@murrayrm murrayrm mentioned this pull request Dec 26, 2020
Release 0.8.4 and 0.9.0 sequencing #451
Closed
@murrayrm
TRV: remove non-essential non-ASCII character for Python 2.7 compatib…
438c178 
…ility
bnavigator
bnavigator approved these changes Dec 27, 2020
View reviewed changes
@murrayrm
murrayrm merged commit bd354c9 into python-control:master Dec 28, 2020
@murrayrm
murrayrm deleted the markov-inconsistency branch December 28, 2020 22:43
@murrayrm murrayrm mentioned this pull request Jan 14, 2021
Use standard time series convention for markov() input data #508
Merged
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

control.matlab.markov does not work

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.