GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — handle empty pole vector for timevector calculation by bnavigator · Pull Request #485 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Dec 29, 2020

Copy link
Copy Markdown
Contributor
  • The automatic timevector calculation sometimes encounters empty vectors. The small random systems used in the test suite sometimes fail (Refactor the test suite using pytest for array and matrix types #438).
  • Escape the LaTeX formula in the docstring to avoid warning messages. Sphinx can still handle it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
handle empty pole vector for timevector calculation
1603e85
@bnavigator bnavigator mentioned this pull request Dec 30, 2020
Refactor the test suite using pytest for array and matrix types #438
Merged
@coveralls

coveralls commented Dec 30, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 86.621% when pulling 1603e85 on bnavigator:timevector-fix into 51c797e on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator requested a review from sawyerbfuller December 30, 2020 16:11
@bnavigator bnavigator mentioned this pull request Dec 30, 2020
Release 0.8.4 and 0.9.0 sequencing #451
Closed
murrayrm
murrayrm approved these changes Dec 30, 2020
View reviewed changes

@murrayrm murrayrm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks fine. The code itself could use some documentation and the reuse of m_u as a subset of p_u is confusing, but not something that needs to be fixed here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
murrayrm merged commit 4eee1f3 into python-control:master Dec 30, 2020
@bnavigator
bnavigator deleted the timevector-fix branch January 5, 2021 20:18
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murrayrm murrayrm murrayrm approved these changes
@sawyerbfuller sawyerbfuller Awaiting requested review from sawyerbfuller

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bnavigator @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.