GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deprecate np.matrix usage by bnavigator · Pull Request #486 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Dec 29, 2020

Copy link
Copy Markdown
Contributor

As previously discussed and announced: 0.9 deprecates np.matrix usage

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coveralls

coveralls commented Dec 30, 2020

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-10.01%) to 76.606% when pulling f9d4a9c on bnavigator:deprecate-matrix into 51c797e on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Dec 30, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 87.04% when pulling 1565097 on bnavigator:deprecate-matrix into c432fd5 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Dec 30, 2020

Copy link
Copy Markdown
Contributor Author

#438 will handle the CI fail: The warning category changed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator mentioned this pull request Dec 30, 2020
Release 0.8.4 and 0.9.0 sequencing #451
Closed
murrayrm
murrayrm approved these changes Dec 30, 2020
View reviewed changes
@roryyorke

roryyorke commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

Assume it's OK to change tests to use np.array instead of np.matrix then? This caught me out while debugging a test failure in canonical_test.py today.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Dec 30, 2020

Copy link
Copy Markdown
Member

You might want to have a look at #438 and wait until that is merged before making changes to tests (they are undergoing significant refactoring).

We are waiting on CI tests to run, but merges should happen today.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator added 2 commits December 30, 2020 21:26
@bnavigator
deprecate np.matrix usage
b83cc15
@bnavigator
print pytest summary for all except passing
1565097
@bnavigator
bnavigator force-pushed the deprecate-matrix branch from f9d4a9c to 1565097 Compare December 30, 2020 20:31
@murrayrm
murrayrm merged commit ec42737 into python-control:master Dec 30, 2020
@bnavigator

bnavigator commented Dec 30, 2020

Copy link
Copy Markdown
Contributor Author

Now that #438 is merged, this passes. But with removing the filter as discussed #438 (comment) it seems that the actual new default is not set properly during the test suite run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator mentioned this pull request Dec 30, 2020
Unit tests do still not use array but matrix by default #488
Closed
@bnavigator
bnavigator deleted the deprecate-matrix branch January 5, 2021 20:18
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murrayrm murrayrm murrayrm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bnavigator @coveralls @roryyorke @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.