GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix loading of defaults during pytest fixture setup by bnavigator · Pull Request #489 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

Also make matarrayout and matarrayin function scoped fixtures so
that they can set the warnings filters individually as needed for
each test.

Fixes #488

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
Fix loading of defaults during pytest fixture setup
abf1565 
Also make matarrayout and matarrayin function scoped fixtures so
that they can set the warnings filters individually as needed for
each test.
@coveralls

coveralls commented Dec 30, 2020

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 86.839% when pulling abf1565 on bnavigator:fix-defaults into d66f4e4 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Dec 30, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.06%) to 86.98% when pulling abf1565 on bnavigator:fix-defaults into d66f4e4 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Dec 31, 2020

Copy link
Copy Markdown
Member

I'm not enough of a pytest guru (yet -:) to understand this in detail. OK by me to merge unless you feel that someone else should have a closer look first.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Dec 31, 2020

Copy link
Copy Markdown
Contributor Author

I think I tested it thoroughly on my local machine. Given that it affects only the test suite and not the end user I feel confident enough to merge it with "just" your OK.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Dec 31, 2020

Copy link
Copy Markdown
Contributor Author

Meh, the 3 uncovered lines in freqplot need some investigation before merging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator mentioned this pull request Dec 31, 2020
test coverage of options for bode_plot with margins #491
Merged
@bnavigator
bnavigator merged commit bbb2e36 into python-control:master Dec 31, 2020
@bnavigator
bnavigator deleted the fix-defaults branch January 5, 2021 20:13
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Unit tests do still not use array but matrix by default

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bnavigator @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.