GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ENH: add bdschur, which calls Slycot mb03rd. Change modal_form to us… by roryyorke · Pull Request #495 · python-control/python-control

Conversation

@roryyorke

@roryyorke roryyorke commented Jan 1, 2021

Copy link
Copy Markdown
Contributor

…e bdschur

The bdschur interface is modelled after the Matlab function of the
same name; it can also optionally sort the modal blocks.

Added tests for bdschur, and modified tests for modal_form.

Closes #318

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coveralls

coveralls commented Jan 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 87.648% when pulling 8fc3627 on roryyorke:rory/modal-form into feb9fc9 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Jan 1, 2021
View reviewed changes

@bnavigator bnavigator left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some comments about the docstrings and test suite. Can't say much about the algorithms themselves.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread control/canonical.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/canonical.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/canonical.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/tests/canonical_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@roryyorke

roryyorke commented Jan 2, 2021

Copy link
Copy Markdown
Contributor Author

Thanks @bnavigator ! I've added the @slycotonly decorator, and updated the docs. I did some minor mods to the other docstrings in canonical.py too, and added bdschur and modal_form to control.rst.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
roryyorke and others added 4 commits January 14, 2021 21:45
@roryyorke @murrayrm
ENH: add bdschur, which calls Slycot mb03rd. Change modal_form to use…
14079fb 
… bdschur

The bdschur interface is modelled after the Matlab function of the
same name; it can also optionally sort the modal blocks.

Added tests for bdschur, and modified tests for modal_form.
@roryyorke @murrayrm
Change docstrings to numpydoc conventions; update doc func index
f630b4a
@roryyorke @murrayrm
Add @slycotonly decorator as needed
7122b07
@murrayrm
update _convertToStateSpace to _convert_to_statespace
8fc3627
@murrayrm
murrayrm force-pushed the rory/modal-form branch from 19102b9 to 8fc3627 Compare January 15, 2021 05:46
@murrayrm

murrayrm commented Jan 15, 2021

Copy link
Copy Markdown
Member

Rebased and changed _convertToStateSpace to _convert_to_statespace. Will merge as soon as Travis finishes up.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit ad0a0eb into python-control:master Jan 15, 2021
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

modal canonical form does not work with repeated eigenvalues

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@roryyorke @coveralls @murrayrm @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.