GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix rlocus plotting problem in Jupyter notebooks + comments, PEP8 by murrayrm · Pull Request #503 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jan 9, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR resolves issue #464. I added some comments to the code along the way as I was trying to sort out what was going wrong. No easy unit tests for this one, I think, since it seems like the issue is restricted to Jupyter notebooks and has to do with the way they generate plots (I guess).

Before (need to zoom way in to see the plot)
jupyter_bug-before

After:
jupyter_bug-after

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
fix rlocus plotting problem in Jupyter notebooks + comments, PEP8
4b88452
@murrayrm murrayrm linked an issue Jan 9, 2021 that may be closed by this pull request
root_locus() plot figure size issue - ipynotebook #464
Closed
@coveralls

coveralls commented Jan 9, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+11.03%) to 87.675% when pulling 4b88452 on murrayrm:fix_rlocus_jupyter into a82b520 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Jan 9, 2021

Copy link
Copy Markdown

Coverage Status

Coverage increased (+10.9%) to 87.537% when pulling 4b88452 on murrayrm:fix_rlocus_jupyter into a82b520 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Jan 9, 2021

Copy link
Copy Markdown
Contributor

LGTM.

Could you post before-after pictures here?

The coveralls increase by 11% is a lie, because the last Travis run on master failed with server errors.

Uncovered line: https://coveralls.io/builds/36205925/source?filename=control%2Frlocus.py#L247. At least call the plot function with a dtime sys once?

Maybe https://matplotlib.org/devel/testing.html#writing-an-image-comparison-test is also worth a try.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit 8194b1d into python-control:master Jan 14, 2021
@murrayrm
murrayrm deleted the fix_rlocus_jupyter branch January 14, 2021 07:04
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

root_locus() plot figure size issue - ipynotebook

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.