GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — change default value of statesp.remove_useless_states to False by murrayrm · Pull Request #509 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jan 15, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR resolves issue #244. It looks like the only issue was that converting a constant to a state space object was creating an extra state and this state had to then be removed. By creating a state space system with no internal state (A = [[]] instead of A=[[0]]), this action is no longer required to get sensible results from block diagram algebra functions.

The PR makes that change and also changes the default value of statesp.remove_useless_states to False.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
change default value of statesp.remove_useless_states to False
114bce6
@coveralls

coveralls commented Jan 15, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 87.65% when pulling b7945f3 on murrayrm:dont_remove_useless_states into ad0a0eb on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller approved these changes Jan 15, 2021
View reviewed changes
bnavigator
bnavigator reviewed Jan 15, 2021
View reviewed changes
Comment thread control/tests/statesp_test.py
assert StateSpace(A0, B0, C1, D1).is_static_gain()
# TODO: fix this once remove_useless_states is false by default
# should be False when remove_useless is false
# print(StateSpace(A1, B0, C1, D1).is_static_gain())

@bnavigator bnavigator Jan 15, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert not StateSpace(A1, B0, C1, D1).is_static_gain() ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
added missing unit test
b7945f3
@bnavigator
bnavigator merged commit b47ed08 into python-control:master Jan 15, 2021
@murrayrm
murrayrm deleted the dont_remove_useless_states branch January 15, 2021 22:03
@murrayrm murrayrm mentioned this pull request Jan 18, 2021
StateSpace constructor should not call _remove_useless_states #244
Closed
@bnavigator bnavigator mentioned this pull request Jan 30, 2021
Undesired model reduction #526
Closed
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments
@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@murrayrm @coveralls @bnavigator @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.