GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — add summing junction + implicit signal interconnection by murrayrm · Pull Request #517 · python-control/python-control Conversation
Member
This PR addresses the enhancement describe in issue #516 where signals with the same name are automatically interconnected by the Other minor changes:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Coverage increased (+0.1%) to 87.754% when pulling 791f7a6 on murrayrm:sumblk_implicit_interconnect into 1502d38 on python-control:master. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Very cool! I particularly like that it appears possible with this to leave out the ‘name’ keyword for the constitutive systems for simple interconnections like this. Am I correct in that? Nice to have that option because thst keyword is somewhat redundant and prone to errors when code gets modified. If you give the sumblock more input names (eg 3 instead of 2), does it sum those three signals? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Correct. The following works just fine (from #516): (
Yup. Any number of inputs can be summed together. The Some possible tweaks:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Awesome. New name for summer sounds better. Hoping this will make creating simulink-like interconnected system simulations much easier. I will let you know how it goes once it’s been merged in. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Very nice! (Now we will have users demanding a graphical editor next 😁. Implemented as jupyter notebook widget or the like.) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think the first step in that direction might be to add an option in
interconnect to draw a block diagram. This could be done using matplotlibs
pretty good capabilities for this.
…--
Sawyer Fuller
Assistant Professor of Mechanical Engineering
Adjunct, Paul G Allen School of Computer Science
University of Washington
http://faculty.washington.edu/~minster/
(Typed with my thumbs)
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| interconneciton map by connecting all signals with the same base names | ||
| (ignoring the system name). Specifically, for each input signal name | ||
| in the list of systems, if that signal name corresponds to the output | ||
| signal in any of the systems, it will be connected to that input (with |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Nice that this summation effect is stated explicitly.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Using interconnect/interconnected system sumblk doesnt exists for connection in matlab compatibility module
There was an error while loading. Please reload this page.