GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Freqplot improvements by sawyerbfuller · Pull Request #522 · python-control/python-control

Conversation

@sawyerbfuller

@sawyerbfuller sawyerbfuller commented Jan 28, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

fixes to freqplot.py:

  • empty glyph in margin plot
  • evalfr(sys,s)->sys(s)
  • changed to a reasonable number of frequency points (1000) in bode plots (up from a very coarse 50)
  • unify frequency range specification between bode and nyquist
    edit:
  • mag/phase data in bode plot is now plotted along with vertical nyquist freq line for DT systems so that it is convenient to call legend(('sys1', 'sys2'))
  • unit tests for frequency ranges

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sawyerbfuller added 14 commits January 28, 2021 08:28
@sawyerbfuller
removed backspace character in margins plot title because it shows as…
bab9f7b 
… an empty glyph (on mac)
@sawyerbfuller
evalfr(sys,s) -> sys(s); mimo errors specified as ControlMIMONotImple…
72c5e06 
…mented in a few places
@sawyerbfuller
freqplot: use reasonable number of frequency points rather than defau…
ddaeb6d 
…lt of 50 for logspace; unify frequency range specification for bode and nyquist
@sawyerbfuller
convert first system passed to append into ss if necessary
70c9855
@sawyerbfuller
a few small code cleanups
65171d3
@sawyerbfuller
fixes to pass tests
060b2f0
@sawyerbfuller
removed backspace character in margins plot title because it shows as…
151fb6c 
… an empty glyph (on mac)
@sawyerbfuller
evalfr(sys,s) -> sys(s); mimo errors specified as ControlMIMONotImple…
ee6a72e 
…mented in a few places
@sawyerbfuller
freqplot: use reasonable number of frequency points rather than defau…
1c0764d 
…lt of 50 for logspace; unify frequency range specification for bode and nyquist
@sawyerbfuller
convert first system passed to append into ss if necessary
08dfca5
@sawyerbfuller
a few small code cleanups
d8b70ed
@sawyerbfuller
fixes to pass tests
5e3c2bb
@sawyerbfuller
Merge branch 'freqplot-improvements' of https://github.com/sawyerbful…
b9a350e 
…ler/python-control into freqplot-improvements
@sawyerbfuller
test bug, changed is to ==
41193c6
@coveralls

coveralls commented Jan 28, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.07%) to 87.685% when pulling 73ce1a6 on sawyerbfuller:freqplot-improvements into 6d51358 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sawyerbfuller
revert some freqplot.nyquist_plot changes because they turned out to …
d195e06 
…be unneccesary and to avoid a merge conbflict with python-control#521
@sawyerbfuller

sawyerbfuller commented Jan 28, 2021

Copy link
Copy Markdown
Contributor Author

added a commit because changes were not necessary and to avoid a merge conflict with #521
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sawyerbfuller
docstring fixes, nyquist now outputs frequency response as specified …
eaf5b16 
…in docstring
sawyerbfuller
sawyerbfuller commented Jan 29, 2021
View reviewed changes
Comment thread control/freqplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller commented Jan 29, 2021
View reviewed changes
Comment thread control/freqplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller commented Jan 29, 2021
View reviewed changes
Comment thread control/tests/sisotool_test.py
bode_mag_moved = np.array(
[111.83321224, 92.29238035, 76.02822315, 62.46884113, 51.14108703,
41.6554004, 33.69409534, 27.00237344, 21.38086717, 16.67791585])
[674.0242, 667.8354, 661.7033, 655.6275, 649.6074, 643.6426,

@sawyerbfuller sawyerbfuller Jan 29, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to Change this because new number of sampling points.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sawyerbfuller
added a few unit tests for frequency range parameter to nyquist and bode
e8d233f
murrayrm
murrayrm reviewed Jan 29, 2021
View reviewed changes
Comment thread control/bdalg.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/bdalg.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/bdalg.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/freqplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/freqplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller and others added 6 commits January 28, 2021 23:41
@sawyerbfuller
plot vertical nyquist freq line at same time as data for legend conve…
fa43785 
…nience eg legend(('sys1','sys2'))
@sawyerbfuller
Update control/freqplot.py
adec95e
@sawyerbfuller
Update control/freqplot.py
b7653f8
@sawyerbfuller
@murrayrm suggested changes e.g change default_frequency_range to pri…
acaea54 
…vate
@sawyerbfuller
Merge branch 'freqplot-improvements' of https://github.com/sawyerbful…
24d57e1 
…ler/python-control into freqplot-improvements

merge!
@sawyerbfuller
allow specified frequency range to exceed nyquist frequency if desired
73ce1a6
murrayrm
murrayrm approved these changes Jan 31, 2021
View reviewed changes
@sawyerbfuller
sawyerbfuller merged commit 73f65df into python-control:master Feb 1, 2021
This was referenced Feb 8, 2021
Freqplot improvements introduced warning messages in tests #538
Closed
Bode, Nyquist, and root locus plots are crude #49
Open
Frequency response plots for discrete time systems with poles/zeros on unit circle #544
Open
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murrayrm murrayrm murrayrm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sawyerbfuller @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.