GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix #523: finding z for |H(z)|=1 computed the wrong polynomials by bnavigator · Pull Request #525 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Jan 30, 2021

Copy link
Copy Markdown
Contributor

Even the reference values for the tests were wrong.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bnavigator added 2 commits January 30, 2021 01:46
@bnavigator
fix python-control#523: finding z for |H(z)|=1 computed the wrong pol…
96cc124 
…ynomials
@bnavigator
revert the removal of rtol for discrete margin test: conda on python3…
48a18d6 
….6 is not as precise
@bnavigator bnavigator linked an issue Jan 30, 2021 that may be closed by this pull request
stability_margins doesn't find gain=1 crossover frequency correctly for DT systems #523
Closed
@coveralls

coveralls commented Jan 30, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 87.754% when pulling 48a18d6 on bnavigator:fix-523 into 6d51358 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller approved these changes Jan 30, 2021
View reviewed changes
@bnavigator
bnavigator merged commit 649215e into python-control:master Jan 30, 2021
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
@bnavigator
bnavigator deleted the fix-523 branch February 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

stability_margins doesn't find gain=1 crossover frequency correctly for DT systems

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bnavigator @coveralls @sawyerbfuller @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.